Skip to content

Commit

Permalink
FIX: Fix duplicate options in ng-options
Browse files Browse the repository at this point in the history
Under angular.js:26629 in the updateOptions function, the
currentElement variable will be assigned to the generated
comment of the ng-if (i.e., <!-- ngIf: !isTaskDefMode -->)
and not the select <option> element.

This is a bug with angular by having a first, default option
in a select with ng-options -- it *must not* have an ng-if
clause on it or duplicate entries are added.
  • Loading branch information
alexcu committed Jan 20, 2017
1 parent 5e2bc94 commit 7ca727b
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
ng-change="taskDefinitionIdChanged()"
autofocus="{{autofocus.onTaskDefinitionSelect}}"
class="form-control input-md">
<option value="" ng-if="!isTaskDefMode">All task definitions</option>
<option value="" ng-hide="!isTaskDefMode">All task definitions</option>
</select>
</div>
<p class="help-block">You can choose to display submissions of a specific task definition here.</p>
Expand Down

0 comments on commit 7ca727b

Please sign in to comment.