Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks/migrate home component #781

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

BrianJCal99
Copy link
Contributor

Description

Replaced FxLayout components with Tailwind equivalent while maintaining the visual appearance and responsiveness of the application. (welcome component)

Before

image

image

image

After

image

image

image

@BrianJCal99
Copy link
Contributor Author

@maddernd

@jakerenzella
Copy link
Member

Looks like an OK start, but some issues:

<span fxFlex="10"></span> -> this should use tailwind's flex basis, although I'm not 100% sure what the equivalent unit would be. Could you look into that?

<span fxFlex="10"></span>
<div id="home" fxFlex>
<div class="flex flex-row">
<span style="flex-basis: 10%"></span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use tailwind

@@ -148,5 +172,5 @@ <h1>Administration</h1>
</div>
</div>
</div>
<span fxFlex="10"></span>
<span style="flex-basis: 10%"></span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here, the rest looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants