-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate/comments-modal component #869
Open
b0ink
wants to merge
11
commits into
doubtfire-lms:8.0.x
Choose a base branch
from
b0ink:migrate/comments-modal
base: 8.0.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
macite
requested changes
Aug 9, 2024
src/app/common/modals/comments-modal/comments-modal.component.html
Outdated
Show resolved
Hide resolved
b0ink
force-pushed
the
migrate/comments-modal
branch
from
September 28, 2024 06:42
9d4a70f
to
d9c64b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Student ID: s222313935
Description
Migrates the
comments-modal
component from CoffeeScript to TypeScript. This component is used to display images and PDFs from the task comments as a fullscreen modal popup, allowing users to view the content without needing to download or open it in another tab.Type of change
How Has This Been Tested?
student_1
and select any unit and any task.comments-modal
is working correctly by clicking on the attachments in the comments and view images in fullscreen or PDFs embedded into the modal.Before (images):
After (images):
Before (PDFs):
After (PDFs):
Testing Checklist:
Checklist:
Component review PR: thoth-tech/documentation#519
ThothTech PR: thoth-tech#218