Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate/comments-modal component #869

Open
wants to merge 11 commits into
base: 8.0.x
Choose a base branch
from

Conversation

b0ink
Copy link

@b0ink b0ink commented Aug 2, 2024

Student ID: s222313935

Description

Migrates the comments-modal component from CoffeeScript to TypeScript. This component is used to display images and PDFs from the task comments as a fullscreen modal popup, allowing users to view the content without needing to download or open it in another tab.

Type of change

  • Migration

How Has This Been Tested?

  • Log in as student_1 and select any unit and any task.
  • Send an image and a PDF into the task comments either by manually attaching the files using the bottom left icon or dragging and dropping it over.
  • Once uploaded, confirm the comments-modal is working correctly by clicking on the attachments in the comments and view images in fullscreen or PDFs embedded into the modal.

Before (images):

comments-modal-image-original

After (images):

comments-modal-image-migrated-final

Before (PDFs):

comments-modal-pdf-original

After (PDFs):

comments-modal-pdf-viewer

comments-modal-pdf-viewer-native

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Component review PR: thoth-tech/documentation#519
ThothTech PR: thoth-tech#218

@b0ink b0ink changed the base branch from 9.x to 8.0.x August 14, 2024 12:03
@b0ink b0ink requested a review from macite August 14, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants