Add random page access at /read #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gh-573 For random page access.
The selected page, used as defaultValue for the select and pagination elements I've added recently, is not updating when you go to a new page using anything but that particular element. That is, if I go to the URL and type in a new hash value, the right page displays, but the page showing as selected in the select and the pagination do not update. Trying to fix this with the key prop, which is normally for lists. Also adding a key to the option items, which more clearly need it. https://stackoverflow.com/questions/30792526/defaultvalue-change-does-not-re-render-input
I actually like how it looks better, but itesting will require changes, because I won't have button text to search for, so I'm staying with "next page" and "previous page" for Passover 2024.
This reverts commit db9c4d8. I got a build failure: > ReferenceError: jsx is not defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-573.
Closes gh-571.