-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make tests run in actions #395
Conversation
Code Climate has analyzed commit 204704d and detected 0 issues on this pull request. View more on Code Climate. |
Pull Request Test Coverage Report for Build 1444
💛 - Coveralls |
@mrchief I don't know, if you want to have tests run differently in GitHub actions. Please comment |
LGTM. |
@@ -18,6 +18,7 @@ jobs: | |||
node-version: 12.x | |||
- run: yarn install --ignore-engines | |||
- run: yarn lint:nofix | |||
- run: yarn test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking back this seems like a duh moment - like how did we miss this? 😄
@mobilutz One of your commits are not signed so the merge is blocked. I can override this but would be great if we can sign the commits in future! |
One thing though, TravisCI fails on my local fork: Maybe this is something, that can be mentioned in the Readme. |
Yeah, that's the coverall flow. It's not supposed to fail on forks - that's the only reason we have Travis CI as GH actions cannot support tokens across forks while Travis can. I suspect something is broken in terms of security. Will take a look at it later. Do you mind creating an issue so that we don't lose sight of it? |
🎉 This PR is included in version 2.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does it do?
This makes
yarn test
run on PullRequests.I think it is good, and as I saw that somehow
coveralls
cannot run, it would be good to have tests run at least.Type of change
Please delete options that are not relevant.
Checklist: