Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make tests run in actions #395

Merged
merged 1 commit into from
Jul 13, 2020
Merged

fix: Make tests run in actions #395

merged 1 commit into from
Jul 13, 2020

Conversation

mobilutz
Copy link
Contributor

@mobilutz mobilutz commented Jul 13, 2020

What does it do?

This makes yarn test run on PullRequests.

I think it is good, and as I saw that somehow coveralls cannot run, it would be good to have tests run at least.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Updated documentation (if applicable)
  • Added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

@codeclimate
Copy link

codeclimate bot commented Jul 13, 2020

Code Climate has analyzed commit 204704d and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1444

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.995%

Totals Coverage Status
Change from base Build 1437: 0.0%
Covered Lines: 601
Relevant Lines: 622

💛 - Coveralls

@mobilutz mobilutz marked this pull request as ready for review July 13, 2020 20:42
@mobilutz
Copy link
Contributor Author

@mrchief I don't know, if you want to have tests run differently in GitHub actions. Please comment

@mrchief
Copy link
Collaborator

mrchief commented Jul 13, 2020

LGTM.

@@ -18,6 +18,7 @@ jobs:
node-version: 12.x
- run: yarn install --ignore-engines
- run: yarn lint:nofix
- run: yarn test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking back this seems like a duh moment - like how did we miss this? 😄

@mrchief
Copy link
Collaborator

mrchief commented Jul 13, 2020

@mobilutz One of your commits are not signed so the merge is blocked. I can override this but would be great if we can sign the commits in future!

@mrchief mrchief merged commit 3c69a67 into dowjones:develop Jul 13, 2020
@mobilutz
Copy link
Contributor Author

mobilutz commented Jul 14, 2020

@mobilutz One of your commits are not signed so the merge is blocked. I can override this but would be great if we can sign the commits in future!

One thing though, TravisCI fails on my local fork:
https://github.com/mobilutz/react-dropdown-tree-select/runs/866804495
https://travis-ci.com/github/mobilutz/react-dropdown-tree-select/builds/175460403

Maybe this is something, that can be mentioned in the Readme.

@mrchief
Copy link
Collaborator

mrchief commented Jul 14, 2020

Yeah, that's the coverall flow. It's not supposed to fail on forks - that's the only reason we have Travis CI as GH actions cannot support tokens across forks while Travis can. I suspect something is broken in terms of security. Will take a look at it later. Do you mind creating an issue so that we don't lose sight of it?

@github-actions
Copy link

🎉 This PR is included in version 2.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mobilutz
Copy link
Contributor Author

@mrchief I added this ticket here:
#397

@mobilutz mobilutz deleted the ll-ci-test-run branch July 14, 2020 20:13
m4theushw pushed a commit to m4theushw/react-dropdown-tree-select that referenced this pull request Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants