-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optionally disable popping on backspace #551
Conversation
…pace Feat/disable popping on backspace
src/index.keyboardNav.test.js
Outdated
t.deepEqual(wrapper.state().tags.length, 2) | ||
triggerOnKeyboardKeyDown(wrapper, 'Backspace') | ||
t.deepEqual(wrapper.state().tags.length, 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, why the double test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, was following the pattern of the previous test but isn't really needed. Want me to change it on the branch and make a new PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's no real purpose, then let's get rid of it. You should be able to push the updates on your branch and this PR should reflect those changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IOW, you don't have to create a new branch or PR everytime you make an edit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, change made.
Code Climate has analyzed commit 4098fc9 and detected 0 issues on this pull request. View more on Code Climate. |
@allcontributors[bot] Let's add @moonjy1993 for code |
@moonjy1993 already contributed before to code |
@allcontributors Let's add @r-zane-spalding for code |
I've put up a pull request to add @r-zane-spalding! 🎉 |
🎉 This PR is included in version 2.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does it do?
Adds disablePoppingOnBackspace prop to allow for optionally disabling the popping of nodes from the tree when the 'backspace' key is pressed in an empty search bar.
Fixes #550
Please mention in the format "Fixes #issueNumber" or "Closes #issueNumber".
This is important for semantic-release to correctly generate release tags and update issues.
Type of change
Please delete options that are not relevant.
Checklist: