Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/disable popping on backspace #1

Merged
merged 7 commits into from
Mar 7, 2022

Conversation

r-zane-spalding
Copy link
Owner

What does it do?

Adds disablePoppingOnBackspace prop to allow for optionally disabling the popping of nodes from the tree when the 'backspace' key is pressed in an empty search bar.

Fixes dowjones#550

Please mention in the format "Fixes #issueNumber" or "Closes #issueNumber".
This is important for semantic-release to correctly generate release tags and update issues.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] Updated documentation (if applicable)
  • [ x] Added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • [ x] My changes generate no new warnings

@r-zane-spalding r-zane-spalding merged commit c7b0ac8 into develop Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Optionally disable popping of items on backspace keydown
1 participant