Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaf padding fix #393

Closed

Conversation

non-engineer-dev
Copy link
Contributor

What does it do?

Added a hidden icon for leaf nodes

Fixes # (issue)

Padding for leaf nodes

Note

Already did in another PR but had pushed package-lock.json by mistake.
Refer to #389 for details.

@codeclimate
Copy link

codeclimate bot commented Jul 13, 2020

Code Climate has analyzed commit 09d70b5 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1442

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.995%

Totals Coverage Status
Change from base Build 1437: 0.0%
Covered Lines: 601
Relevant Lines: 622

💛 - Coveralls

@mrchief
Copy link
Collaborator

mrchief commented Jul 13, 2020

This PR will not work (more related to how git works). You need to delete the package lock file, stage that change and push. Also add an entry to gitignore so it doesn't get added in future. In that order... :)

@mrchief
Copy link
Collaborator

mrchief commented Jul 13, 2020

Also, make sure your title matches conventional commits. If you click on the details link on the failed check, you can learn more.

@non-engineer-dev
Copy link
Contributor Author

This PR will not work (more related to how git works). You need to delete the package lock file, stage that change and push. Also add an entry to gitignore so it doesn't get added in future. In that order... :)

Oh no problem. I will understand it for future purposes. I think @mobilutz took care of it in another PR.

Also, make sure your title matches conventional commits. If you click on the details link on the failed check, you can learn more.

Oh got it! I followed the convention in the commit message but not the PR title. I will take care from next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants