Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove package-lock.json and add CI checks #394

Merged
merged 1 commit into from
Jul 14, 2020
Merged

fix: Remove package-lock.json and add CI checks #394

merged 1 commit into from
Jul 14, 2020

Conversation

mobilutz
Copy link
Contributor

What does it do?

This removes the package-lock.json file, and adds a test to check for this:

  • package-lock.json does not exist
  • yarn.lock exists

Fixes # (issue)

There is no GitHub issue yet, but the latest release brought up this issue for us:
#389 (comment)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Updated documentation (if applicable)
  • Added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

@mobilutz mobilutz mentioned this pull request Jul 13, 2020
Merged
codeclimate[bot]
codeclimate bot reviewed Jul 13, 2020
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 25776 lines exceeds the maximum allowed for the inline comments feature.

@coveralls
Copy link

coveralls commented Jul 13, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1448

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.995%
Totals Coverage Status
Change from base Build 1445: 0.0%
Covered Lines: 601
Relevant Lines: 622
💛 - Coveralls

@mrchief
Copy link
Collaborator

mrchief commented Jul 13, 2020

Looks good. I'd add a gitignore just to be safe.

codeclimate[bot]
codeclimate bot reviewed Jul 14, 2020
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 25779 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Jul 14, 2020
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 25779 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Jul 14, 2020
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 25779 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Jul 14, 2020

Code Climate has analyzed commit d203bf3 and detected 0 issues on this pull request.

View more on Code Climate.

@mobilutz
Copy link
Contributor Author

Looks good. I'd add a gitignore just to be safe.

@mrchief added package-lock.json to gitignore and now my commits are also signed correctly 😉

@mrchief mrchief changed the title Fix: Remove package-lock.json and add test to check that it does not enter again fix: Remove package-lock.json and add CI checks Jul 14, 2020
@mrchief mrchief merged commit 9b5f51c into dowjones:develop Jul 14, 2020
@github-actions
Copy link

🎉 This PR is included in version 2.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mobilutz mobilutz deleted the ll-test-lock-files branch July 14, 2020 19:59
m4theushw pushed a commit to m4theushw/react-dropdown-tree-select that referenced this pull request Sep 20, 2020
@mobilutz @m4theushw
fix: Remove package-lock.json and add CI checks (dowjones#394)
a2ed4d3 
- add test to check that it does not enter again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate CodeClimate codeclimate left review comments

@mrchief mrchief mrchief approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mobilutz @coveralls @mrchief