Vim Keybindings #115
Vim Keybindings #115
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/downforacross/downforacrosscom/f5oa4x90y |
|
|
||
| const {onVimNormal, onVimInsert, vimInsert, onPressEnter, onPressPeriod} = this.props; | ||
| if (key in actionKeys) { | ||
| this.handleAction(actionKeys[key], shiftKey); |
There was a problem hiding this comment.
return true to prevent tab default behavior
There was a problem hiding this comment.
i noticed this bug but was having trouble figuring out why it was happening. thanks!
| x: 'delete', | ||
| ' ': 'space', | ||
| '[': 'backward', | ||
| ']': 'forward', |
There was a problem hiding this comment.
w -> selectNextClue(true), b -> selectNextClue(false) ? :D
There was a problem hiding this comment.
and maybe dd for delete word, though that's a bit unintuitive when it's vertical i guess
There was a problem hiding this comment.
i added w and b (good suggestions!) but haven't added dd yet since it seems like it would take some more work (need to add some queue state to check for the first d. I could take a stab at it in another PR along with some other ideas I had e.g. use :32 to go to clue 32.
src/components/Toolbar/index.js
Outdated
| const {vimMode, vimInsert} = this.props; | ||
| return ( | ||
| <ActionMenu | ||
| label={vimMode ? `VIM ${vimInsert ? 'Insert' : 'Normal'}` : 'Normal'} |
There was a problem hiding this comment.
I think VIM Normal is a bit confusing at first glance. maybe strings can be
NormalVIMVIM (insert)
|
Hi @stevenhao , I made the changes you mentioned. |
|
Amazing :) |
This is more of a proof of concept (the actual code needs more cleanup work and there are some design questions that need to be addressed here), but I've managed to implement vim keybindings to the frontend. My changes adds a new action menu which allows you to switch from normal mode to vim mode. Vim mode should allow
hjklfor navigation andxfor deleting in normal mode, and all the original action keys from insert mode. To switch into insert mode useiand to switch back to normal mode useEscpape. If you could look at it and tell me what you think, that'd be great :).