fix(useCombobox): dispatch on Enter keydown event #1150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Call dispatch on
Enter
keydown.Prevent event default (form submission) if menu is open.
Do not return highlightedIndex from reducer if menu is closed.
Fix the MUI example for useSelect on the docsite.
Why:
Fixes #1114.
Also to fix other potential issues.
How:
Fix the reducer for the
useCombobox
hook.Add itemsAsObjects to the MUI example useCombobox hook.
Check state.isOpen before returning a
highlightedIndex
in the Home/End actions.Checklist: