Loosen dependencies #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) SuperSpreader::SchedulerJob#next_run_at is the configured amount of time in the future
Failure/Error: pipeline.hset(redis_key, key, value)
TypeError:
Unsupported command argument type: NilClass
# ./lib/super_spreader/redis_model.rb:33:in `block (2 levels) in save'
# ./lib/super_spreader/redis_model.rb:32:in `each'
# ./lib/super_spreader/redis_model.rb:32:in `block in save'
# ./lib/super_spreader/redis_model.rb:29:in `save'
# ./spec/scheduler_job_spec.rb:94:in `block (4 levels) in <top (required)>'
# ./spec/scheduler_job_spec.rb:93:in `block (3 levels) in <top (required)>'
# ./spec/spec_helper.rb:62:in `block (2 levels) in <top (required)>'
benjaminoakes
commented
Jun 28, 2023
| @@ -91,7 +91,7 @@ | |||
| describe "#next_run_at" do | |||
| it "is the configured amount of time in the future" do | |||
| travel_to(Time.new(2020, 12, 16, 0, 0, 0, 0)) do | |||
| SuperSpreader::SchedulerConfig.new(duration: 3600).save | |||
| create(:scheduler_config, duration: 3600) | |||
benjaminoakes
commented
Jun 28, 2023
Comment on lines
-39
to
+41
| spec.add_development_dependency "rake", "~> 10.0" | ||
| spec.add_development_dependency "rspec", "~> 3.0" | ||
| spec.add_development_dependency "rspec-rails", "~> 4.0" | ||
| spec.add_development_dependency "rake" | ||
| spec.add_development_dependency "rspec" | ||
| spec.add_development_dependency "rspec-rails" |
There was a problem hiding this comment.
It was necessary to remove these ranges so I could test. We also don't really care about versions of development dependencies as long as we have Gemfile.lock.
ezilocchi
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39