Document installation and usage #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminoakes
commented
Jan 26, 2023
| @@ -18,7 +18,7 @@ Please also see "Roadmap" for other known limitations that may be relevant to yo | |||
|
|
|||
| ## History | |||
There was a problem hiding this comment.
Please read the entire README https://github.com/doximity/super_spreader/blob/benjaminoakes/document-installation-and-usage/README.md
jericdeleon
reviewed
Jan 26, 2023
benjaminoakes
changed the title
benjaminoakes
force-pushed
the
benjaminoakes/document-installation-and-usage
branch
from
3498930
to
3f03f3b
Compare
benjaminoakes
commented
Jan 27, 2023
| @@ -29,7 +29,7 @@ | |||
|
|
|||
| expect(log).to eq(<<~LOG) | |||
| {"subject":"SuperSpreader::SchedulerJob","started_at":"2020-12-16T00:00:00Z"} | |||
| {"subject":"SuperSpreader::SchedulerJob","batch_size":80,"duration":3600,"job_class_name":"ExampleBackfillJob","per_second_on_peak":3.0,"per_second_off_peak":3.0,"on_peak_timezone":"America/Los_Angeles","on_peak_hour_begin":5,"on_peak_hour_end":17,"on_peak_wday_begin":1,"on_peak_wday_end":5} | |||
| {"subject":"SuperSpreader::SchedulerJob","job_class_name":"ExampleBackfillJob","batch_size":80,"duration":3600,"per_second_on_peak":3.0,"per_second_off_peak":3.0,"on_peak_timezone":"America/Los_Angeles","on_peak_hour_begin":5,"on_peak_hour_end":17,"on_peak_wday_begin":1,"on_peak_wday_end":5} | |||
There was a problem hiding this comment.
Changing the order in lib/super_spreader/scheduler_config.rb changed the serialization order.
ezilocchi
reviewed
Feb 6, 2023
benjaminoakes
deleted the
benjaminoakes/document-installation-and-usage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document installation and usage for both internal and external consumption.
I'm not expecting many more changes to the README before this is released as open source. (I may make one breaking change to an interface though. Still considering that.)