Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream FindIconv #10887

Closed
Croydon opened this issue May 22, 2024 · 2 comments
Closed

Use upstream FindIconv #10887

Croydon opened this issue May 22, 2024 · 2 comments
Labels
install/build bug in the installation or build scripts

Comments

@Croydon
Copy link
Contributor

Croydon commented May 22, 2024

Similar to e5c7503 I think it is a good idea to switch to upstream FindIconv

CMake's FindIconv is available since CMake 3.11, so no CMake version bump required https://cmake.org/cmake/help/latest/module/FindIconv.html

@Croydon
Copy link
Contributor Author

Croydon commented May 22, 2024

Please note that the upstream FindIconv uses a Iconv_ instead of ICONV_ prefix for CMake variables, so that needs to be adjusted too in Doxygen's usage.

I am currently trying to update Conan's package for doxygen, we are are currently shipping CMake patches for it, to use the upstream names (which also makes it working with Conan specific things) https://github.com/conan-io/conan-center-index/blob/2587e89c258640a1d169298aecb85e1b318db37f/recipes/doxygen/all/patches/1.9.4-0002-fix-iconv-linkage.patch

Croydon added a commit to Croydon/doxygen that referenced this issue May 22, 2024
@albert-github albert-github added the install/build bug in the installation or build scripts label May 23, 2024
Croydon added a commit to Croydon/doxygen that referenced this issue May 23, 2024
doxygen added a commit that referenced this issue May 25, 2024
@doxygen doxygen added the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label May 25, 2024
@doxygen
Copy link
Owner

doxygen commented Aug 7, 2024

This issue was previously marked 'fixed but not released',
which means it should be fixed in doxygen version 1.12.0.
Please verify if this is indeed the case. Reopen the
issue if you think it is not fixed and please include any additional information
that you think can be relevant (preferably in the form of a self-contained example).

@doxygen doxygen removed the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label Aug 7, 2024
@doxygen doxygen closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install/build bug in the installation or build scripts
Projects
None yet
Development

No branches or pull requests

3 participants