React forward ref #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice nice! |
hartzis
commented
Aug 11, 2018
| <ComponentWrapper /> | ||
| <div> | ||
| <ComponentWrapper /> | ||
| </div> |
There was a problem hiding this comment.
i think ReactTestUtils.renderIntoDocument changed a bit with react versions, so we aren't able to just have the Component render then call unmountComponentAtNode, i needed to wrap in a div 🤷♂️
|
i'd like to get a v |
…st, use object spread
|
@dozoisch mind giving this a final review? if good let's get a release candidate out? |
dozoisch
approved these changes
Aug 13, 2018
|
Published as the @next tag! Should be available on npm. :) |
|
@hartzis Amazing work, thank you so much for pushing all of this through 🎉 |
|
no worries! thank you for being so responsive, helpful, and available!
On Sun, Aug 12, 2018 at 18:52 Hugo Dozois ***@***.***> wrote:
@hartzis <https://github.com/hartzis> Amazing work, thank you so much for
pushing all of this through 🎉
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFISk2aUSRa6Df-vpO0RMfRsAZhRkBCnks5uQM24gaJpZM4V3NvO>
.
--
Brian Hartz
www.hartzis.me <http://www.hartzis.me/about>
brianhartz@gmail.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forwardRefgetComponentTODO:
i'd like to get a v
1.0.0-rc1release candidate out there soonish so i can start using in codesandbox and maybe get areact-google-recaptcharelease candidate v1.0.0out using this release candidate 😸