Handle SSLWantReadError and SSLWantWriteErrors on recv and send. #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
SSLSocket
,recv()
andsend()
may raiseSSLWantReadError
orSSLWantWriteError
when the SSL socket is not yet ready to receive or send. In my experience, this tends to occur when e.g. sending large messages.Currently, the SimpleWebSocketServer can't handle this and will drop the connection even though the connection is fine. Python docs recommend to catch these and retry after another call to
select()
. This PR adds try/except forSSLWantReadError
andSSLWantWriteError
to do just that.Note: there is also some mention about calling
SSLSocket.recv()
to drain potentially available data before blocking onselect()
, but it seems like this is already covered by 3bd885a (relevant discussion: #48).This would also fix #87.