Merge branch 'develop' into feature/campaign-feedback

dpc-sdp · Jun 7, 2024 · 3f27356 · 3f27356
2 parents 3ba2a12 + 974f4c3
commit 3f27356
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/packages/ripple-ui-core/src/components/media-embed/RplMediaEmbed.vue b/packages/ripple-ui-core/src/components/media-embed/RplMediaEmbed.vue
@@ -73,7 +73,7 @@ const imageAspect = computed(() => {
     case 'landscape':
       return 'wide'
     case 'portrait':
-      return 'full'
+      return 'portrait'
     case 'square':
       return 'square'
     case 'avatar':

diff --git a/packages/ripple-ui-core/src/styles/components/_embed.css b/packages/ripple-ui-core/src/styles/components/_embed.css
@@ -20,7 +20,8 @@
   /* Portrait */
   &.rpl-media-embed__image--portrait {
     &.rpl-media-embed__image--large {
-      max-width: none;
+      width: auto;
+      height: auto;
       max-height: 595px;
     }
   }
@@ -97,6 +98,7 @@
 
 .rpl-media-embed__actions-list {
   margin-top: var(--rpl-sp-3);
+  max-width: var(--rpl-content-max-width);
 
   li {
     margin-bottom: var(--rpl-sp-3);

diff --git a/packages/ripple-ui-core/src/styles/utilities/_aspect.css b/packages/ripple-ui-core/src/styles/utilities/_aspect.css
@@ -1,15 +1,15 @@
 .rpl-u-aspect {
-  @each $name, $ratio in (square, full, wide, ultrawide, panorama),
-    (1/1, 4/3, 16/9, 21/9, 3/1)
+  @each $name, $ratio in (square, full, wide, ultrawide, panorama, portrait),
+    (1/1, 4/3, 16/9, 21/9, 3/1, 3/4)
   {
     &-$(name) {
       aspect-ratio: $(ratio);
     }
   }
 
   @each $size in (s, m, l, xl) {
-    @each $name, $ratio in (square, full, wide, ultrawide, panorama),
-      (1/1, 4/3, 16/9, 21/9, 3/1)
+    @each $name, $ratio in (square, full, wide, ultrawide, panorama, portrait),
+      (1/1, 4/3, 16/9, 21/9, 3/1, 3/4)
     {
       &-$(name)-$(size) {
         /* stylelint-disable-next-line media-query-no-invalid */