Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map: add clustering distance prop #1290

Closed
3 of 4 tasks
bgilhome-now opened this issue Aug 13, 2024 · 4 comments
Closed
3 of 4 tasks

Map: add clustering distance prop #1290

bgilhome-now opened this issue Aug 13, 2024 · 4 comments
Assignees
Labels
Proposal - Implemented Proposal has been implemented

Comments

@bgilhome-now
Copy link
Contributor

Describe the feature

Depending on the number/spread of markers in a map, it might be useful/desired to set the clustering distance, or even disable clustering. Adding clusteringDistance as an optional prop to RplMap (with default as current at 100) could achieve this.

Motivation

In the current EPA project, the custom map uses RplMap to render the map & markers. However, there are instances where the client would like to disable clustering.

Proposal

Add clusteringDistance as an optional prop to RplMap and pass to the ol-animated-clusterlayer component in the template. PR will be created for this.

Benefits

More control over clustering.

Drawbacks

Possibility of developers setting non-sensible clustering distance values.

Adoption strategy

Update documentation - on breaking changes.

Additional information

  • Would you be willing to help implement this feature?
  • Could this feature be created outside of Ripple-framework as a layer?

Final checks

@bgilhome-now
Copy link
Contributor Author

PR above.

@dylankelly dylankelly added Proposal - planned and removed Proposal - Draft New feature proposal labels Aug 13, 2024
@dylankelly
Copy link
Contributor

thanks @bgilhome-now - PR looks good, its low risk so I'm happy to get it into next release 2.14.0.

@dylankelly dylankelly added Proposal - Implemented Proposal has been implemented and removed Proposal - planned labels Aug 13, 2024
@bgilhome-now
Copy link
Contributor Author

Great, thanks all!

@dylankelly
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposal - Implemented Proposal has been implemented
Projects
None yet
Development

No branches or pull requests

2 participants