Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/map clustering distance prop #1291

Conversation

bgilhome-now
Copy link
Contributor

Issue:
PR to accompany feature request #1290

What I did

  • Added optional clusteringDistance prop to RplMap & passed it to ol-animated-clusterlayer in the template
  • Added Map 'Clustering Nearer' & 'Clustering Disabled' stories to Storybook

How to test

  • See the new stories in the Storybook and confirm clustering behaviour has changed

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@dylankelly dylankelly added this to the v2.14.0 milestone Aug 13, 2024
@dylankelly dylankelly changed the base branch from develop to release/2.14.0 August 13, 2024 04:15
@dylankelly
Copy link
Contributor

@bgilhome-now thanks for the PR, going to merge this into the 2.14.0 release, this is scheduled for this Thursday

Closes #1290

@dylankelly dylankelly merged commit 2208716 into dpc-sdp:release/2.14.0 Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants