Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1736] update results key for interop, collection 'theme' improvements #1022

Merged

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Feb 1, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1736

What I did

  • Update results key for interoperability between search listing and custom collections
  • Update collection 'theming'
  • Minor spacing fix on collection search

Notes

  • Currently the form 'theme' is partially hard coded and partially based off of whether a map is present, this update just wraps form theme into a single formTheme option. This does mean formTheme will need to be added to existing map forms, going by confluence we only have one so far and it not live, so this update seems fine from that point of view.

Screenshot

Spacing issue:
collection-spacing-on-load

Default pages - default form theme:
default-theme

Alt pages - default form theme:
alt-pages-default

Default and alt pages - reverse form theme:
reverse-theme

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit ea4c0f4
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65bc10a59b24da00082e4af9

Copy link

cypress bot commented Feb 1, 2024

Passing run #1225 ↗︎

0 122 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-tide-search): update reverse form theme for alt pages
Project: ripple-framework Commit: ea4c0f4b72
Status: Passed Duration: 05:43 💡
Started: Feb 1, 2024 9:46 PM Ended: Feb 1, 2024 9:52 PM

Review all test suite changes for PR #1022 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Feb 4, 2024
Merged via the queue into develop with commit c82a42e Feb 4, 2024
8 checks passed
@dylankelly dylankelly deleted the feature/R20-1736-collection-listing-interoperability branch February 4, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants