Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1546] update avatar content margin #1027

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Feb 6, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1546

What I did

  • We recently updated the promo card margin as per: "Spacing should be consistent across all promo cards across all breakpoints. Token that should be used is rpl-sp-3 (12px) promo cards ONLY", turns out the avatar cards are promo cards in the design system so we just need to update avatar cards as well.

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 5ca75d3
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65c185f313c18700088e3a40

Copy link

cypress bot commented Feb 6, 2024

Passing run #1239 ↗︎

0 124 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-ui-core): update avatar content margin
Project: ripple-framework Commit: 5ca75d3da4
Status: Passed Duration: 05:58 💡
Started: Feb 6, 2024 1:04 AM Ended: Feb 6, 2024 1:10 AM

Review all test suite changes for PR #1027 ↗︎

@waitingallday waitingallday added this pull request to the merge queue Feb 7, 2024
Merged via the queue into develop with commit 33ada17 Feb 7, 2024
15 of 16 checks passed
@waitingallday waitingallday deleted the bugfix/R20-1546-promo-spacing branch February 7, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants