Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1656] Add image captions in content #1028

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/R20-1656

What I did

  • Transpose image captions from raw source with cheerio
  • RplContent images are now wrapped in a <figure> to accommodate a <figcaption> if it exists
  • Update unit tests

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 5bf23a8
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65c3344f4e68e6000805c8be

Copy link

cypress bot commented Feb 7, 2024

Passing run #1251 ↗︎

0 124 0 0 Flakiness 0

Details:

feat: ✨ add image captions in content
Project: ripple-framework Commit: 5bf23a8ff6
Status: Passed Duration: 05:44 💡
Started: Feb 7, 2024 7:42 AM Ended: Feb 7, 2024 7:48 AM

Review all test suite changes for PR #1028 ↗︎

@waitingallday waitingallday added this pull request to the merge queue Feb 7, 2024
Merged via the queue into develop with commit 003e0b1 Feb 7, 2024
16 checks passed
@waitingallday waitingallday deleted the feat/r20-1656-image-captions branch February 7, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants