Update Nuxt to 3.11.2 #1041
Merged
Update Nuxt to 3.11.2 #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ripple-docs canceled.
|
Passing run #1650 ↗︎
Details:
Review all test suite changes for PR #1041 ↗︎ |
|||||||||||||||
dylankelly
force-pushed
the
feature/update-nuxt
branch
from
0645ce9
to
9a44515
Compare
dylankelly
commented
Mar 17, 2024
| @@ -50,5 +50,6 @@ const processedNav = navigation?.map((level1Item) => { | |||
|
|
|||
| .docs-section-link { | |||
| margin-top: var(--rpl-sp-3); | |||
| color: var(--rpl-clr-black); | |||
There was a problem hiding this comment.
removing tailwind required some styling changes
dylankelly
commented
Mar 17, 2024
| @@ -0,0 +1,36 @@ | |||
| <template> | |||
There was a problem hiding this comment.
removing tailwind, we needed to define our own header renderers
dylankelly
commented
Mar 18, 2024
| @@ -48,9 +48,6 @@ const config: StorybookConfig = { | |||
| name: '@storybook/vue3-vite', | |||
| options: {} | |||
| }, | |||
| features: { | |||
There was a problem hiding this comment.
This was previously required for docs site to work as they shared mdx dependencies. Now no longer needed.
dylankelly
commented
Mar 18, 2024
| @@ -61,7 +61,9 @@ Given( | |||
| route: '/api/tide/page', | |||
| status, | |||
| response, | |||
| query: `?path=${path}&site=${Cypress.env('NUXT_PUBLIC_TIDE_SITE')}` | |||
| query: `?path=${encodeURIComponent(path)}&site=${Cypress.env( | |||
| 'NUXT_PUBLIC_TIDE_SITE' | |||
There was a problem hiding this comment.
This is required due to Nuxt useFetch now encoding url params automatically
dylankelly
commented
Mar 24, 2024
| @@ -546,7 +547,7 @@ const reverseFields = computed( | |||
|
|
|||
| <template v-if="activeTab === 'map'"> | |||
| <TideSearchListingResultsMap | |||
| v-if="mapFeatures" | |||
| v-if="mapFeatures && firstLoad" | |||
There was a problem hiding this comment.
Adding a wait here to ensure the map data is actually loaded before attempting to render it, there were lots of issues without it
6 tasks
chore(@dpc-sdp/ripple-test-utils): added test util build script back after nuxt update chore: updated vue version to fix build chore(docs): got docs site running again after nuxt upgrade build: 🔧 map uncrypto chore: update to latest nuxt and vue chore: ⬆️ upgrade to nuxt 3.10.2 and fix vue version Fix Vue version to resolve issue with vue openlayers chore(docs): ⬆️ upgrade docs and storybooks deps remove unused remove tailwind from docs site, remove unused deps from storybook chore(@dpc-sdp/nuxt-ripple): export types for nuxt ripple and fix import chore: upgrade nuxt kit dependencies fix(@dpc-sdp/ripple-ui-maps): ⬆️ update to latest vue-3-openlayers, fix upgrade issues refactor: ⬆️ upgrade vueuse, force using nuxt vue version chore(@dpc-sdp/ripple-test-utils): 🐛 urlencode mock query path to match Nuxt usefetch change fix(@dpc-sdp/ripple-ui-forms): 🐛 prevent error when inputErrors is undefined fix(@dpc-sdp/nuxt-ripple): 🐛 move duplicate vue version hack to nuxt-ripple test(@dpc-sdp/ripple-ui-maps): fix flakey map test ci(@dpc-sdp/ripple-ui-maps): skip failing maps tests relating tile requests chore: cleanup nuxt and vue versions build: update lockfile build: revert jest config change and fix storybook fail build: instrall new playwright version fix(docs): remove iframe border chore: update lockfile
dylankelly
force-pushed
the
feature/update-nuxt
branch
from
5d551ae
to
353101f
Compare
16 tasks
…feedback removed coupling with rpl-button component to avoid fighting with overrides
packages/nuxt-ripple-cli/src/commands/add/_templates/add/ui-lib/package.json.t
Outdated
Show resolved
Hide resolved
waitingallday
approved these changes
Apr 24, 2024
lambry
approved these changes
Apr 28, 2024
maps were crashing unless the empty controls array was removed from the ol-map component, we are hiding the zoom control via css as an interim solution
…unt instead of hide
dylankelly
force-pushed
the
feature/update-nuxt
branch
from
9afe8ca
to
87e40e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
How to test
Checklist
For all PR's
For new components only