Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1615] don't show no-results message before searching #1070

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Mar 14, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1615

What I did

  • Don't show no-results message before searching, this applies to the main search page and content collections

search-loading

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

Copy link

cypress bot commented Mar 14, 2024

Passing run #1403 ↗︎

0 137 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-search): add back extra searchState.isLoading check
Project: ripple-framework Commit: b2dfc991b3
Status: Passed Duration: 06:57 💡
Started: Mar 14, 2024 11:50 PM Ended: Mar 14, 2024 11:57 PM

Review all test suite changes for PR #1070 ↗︎

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit b2dfc99
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65f38c848fdc600008c36832

David Featherston added 2 commits March 15, 2024 10:29
@lambry lambry added this pull request to the merge queue Mar 15, 2024
Merged via the queue into develop with commit 71238c4 Mar 15, 2024
16 checks passed
@lambry lambry deleted the bugfix/R20-1615-no-result-display branch March 15, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants