Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make links relative to avoid full refresh #1078

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Mar 19, 2024

What I did

  • TO DISCUSS: This is a simple change but potentially controversial as it's effects all links, the upside of this method is we get client side routing for search results, search listings, custom collections, content collections, topic tags, etc.

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit c391b84
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65f9178113caf00008899f53

@dylankelly dylankelly added this to the 2.8 milestone Mar 21, 2024
@dylankelly dylankelly added this pull request to the merge queue Mar 27, 2024
Merged via the queue into develop with commit 38d0eef Mar 27, 2024
8 checks passed
@dylankelly dylankelly deleted the feature/maybe-use-relative-links branch March 27, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants