Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1834] add styles only for initially open sections #1079

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[R20-1834] add styles only for initially open sections #1079

merged 1 commit into from
Mar 21, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Mar 20, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1834

What I did

  • Add styles only for initially open sections so content doesn't overflow on first open

refine-search

  • This still works for the search listings that start with the filters open

open-by-default

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Mar 20, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 20, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 226d1d5
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65fa6b990753bb000826d03a

waitingallday
waitingallday approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@waitingallday waitingallday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@dylankelly dylankelly added this pull request to the merge queue Mar 21, 2024
Merged via the queue into develop with commit 2e2c01b Mar 21, 2024
16 checks passed
@dylankelly dylankelly deleted the feature/R20-1834-expandable-content branch March 21, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly