Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SRM-1284] use tide version of secondary campaign #1083

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[SRM-1284] use tide version of secondary campaign #1083

merged 1 commit into from
Mar 21, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Mar 21, 2024

Issue: https://digital-vic.atlassian.net/browse/SRM-1284

What I did

  • Use TideSecondaryCampaign so secondary banner works
Screenshot 2024-03-21 at 10 51 17 AM

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Mar 21, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 21, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 98dbb44
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/65fb79e2a5dda000084447ed

@cypress Cypress
Copy link

cypress bot commented Mar 21, 2024

Passing run #1448 ↗︎

0 138 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-search): use tide version of secondary campaign
Project: ripple-framework Commit: 98dbb447be
Status: Passed Duration: 06:39 💡
Started: Mar 21, 2024 12:00 AM Ended: Mar 21, 2024 12:07 AM

Review all test suite changes for PR #1083 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Mar 21, 2024
Merged via the queue into develop with commit c301112 Mar 21, 2024
8 checks passed
@dylankelly dylankelly deleted the bugfix/SRM-1284-fix-search-listing-secondary-campaign branch March 21, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly