Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-428] update CSS loading order for storybook #1116

Merged
merged 1 commit into from
Apr 21, 2024
Merged

[R20-428] update CSS loading order for storybook #1116

merged 1 commit into from
Apr 21, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Apr 18, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-428

What I did

  • update CSS loading order for forms story, so it matches a real site

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Apr 18, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 18, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 5f2b758
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/66206d9604e42f0008e907df

@cypress Cypress
Copy link

cypress bot commented Apr 18, 2024

Passing run #1555 ↗︎

0 140 0 0 Flakiness 0

Details:

chore(@dpc-sdp/ripple-ui-core): update CSS loading order for storybook
Project: ripple-framework Commit: 5f2b758317
Status: Passed Duration: 07:22 💡
Started: Apr 18, 2024 12:48 AM Ended: Apr 18, 2024 12:56 AM

Review all test suite changes for PR #1116 ↗︎

@lambry lambry added this pull request to the merge queue Apr 21, 2024
Merged via the queue into develop with commit 1959bda Apr 21, 2024
15 of 16 checks passed
@lambry lambry deleted the bugfix/R20-428-labels-feedback branch April 21, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly