Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1881] - Updated map key styling after design feedback #1132

Merged
merged 1 commit into from
Apr 29, 2024
Merged

[R20-1881] - Updated map key styling after design feedback #1132

merged 1 commit into from
Apr 29, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/R20-1881

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Apr 23, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 23, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 733a50c
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6628362e5ae9e000098cd75a

@cypress Cypress
Copy link

cypress bot commented Apr 23, 2024

Passing run #1610 ↗︎

0 146 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-ui-maps): updated map key styling after design feedback
Project: ripple-framework Commit: 733a50cc3f
Status: Passed Duration: 07:35 💡
Started: Apr 23, 2024 10:32 PM Ended: Apr 23, 2024 10:40 PM

Review all test suite changes for PR #1132 ↗︎

@jeffdowdle jeffdowdle added this pull request to the merge queue Apr 29, 2024
Merged via the queue into develop with commit 6a5426d Apr 29, 2024
8 checks passed
@jeffdowdle jeffdowdle deleted the bugfix/R20-1881-legend-feedback branch April 29, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@lambry lambry Awaiting requested review from lambry

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffdowdle @waitingallday @dylankelly