Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@dpc-sdp/ripple-ui-core): remove unused import to appease eslint #1136

Merged
merged 2 commits into from
May 2, 2024
Merged

fix(@dpc-sdp/ripple-ui-core): remove unused import to appease eslint #1136

merged 2 commits into from
May 2, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Apr 26, 2024

What I did

  • remove unused import to appease eslint

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Apr 26, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 26, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 4279230
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/663036e7f0abb70008d3e2a5

@cypress Cypress
Copy link

cypress bot commented Apr 26, 2024 •
edited
Loading

Passing run #1633 ↗︎

0 148 0 0 Flakiness 0

Details:

Merge branch 'develop' into bugfix/minor-lint-warning
Project: ripple-framework Commit: 427923090c
Status: Passed Duration: 07:55 💡
Started: Apr 30, 2024 12:13 AM Ended: Apr 30, 2024 12:21 AM

Review all test suite changes for PR #1136 ↗︎

@lambry lambry added this pull request to the merge queue May 2, 2024
Merged via the queue into develop with commit 13a50f0 May 2, 2024
15 of 16 checks passed
@lambry lambry deleted the bugfix/minor-lint-warning branch May 2, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@dylankelly dylankelly Awaiting requested review from dylankelly

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @jeffdowdle