Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1923] add search listings to site search #1171

Merged
merged 1 commit into from
May 21, 2024
Merged

[R20-1923] add search listings to site search #1171

merged 1 commit into from
May 21, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented May 20, 2024 •
edited
Loading

Issue: https://digital-vic.atlassian.net/browse/R20-1923

What I did

  • Add search listings to site search

How to test

  • Search for a search listing

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this May 20, 2024
@netlify Netlify
Copy link

netlify bot commented May 20, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 69d0022
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/664a9a7e3a0a7f00084ed47c

@cypress Cypress
Copy link

cypress bot commented May 20, 2024 •
edited
Loading

Passing run #1739 ↗︎

0 150 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-tide-search): add search listings to site search
Project: ripple-framework Commit: 69d00220ed
Status: Passed Duration: 07:14 💡
Started: May 20, 2024 1:37 AM Ended: May 20, 2024 1:44 AM

Review all test suite changes for PR #1171 ↗︎

@dylankelly dylankelly added this pull request to the merge queue May 21, 2024
Merged via the queue into develop with commit a26b5e5 May 21, 2024
8 checks passed
@dylankelly dylankelly deleted the feature/R20-1923-search-listings-in-search branch May 21, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

Assignees

@lambry lambry

Labels
uncontroversial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lambry @waitingallday @dylankelly @jeffdowdle