Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(@dpc-sdp/ripple-ui-core): cleanup vue component exports #1173

Merged
merged 1 commit into from
May 21, 2024
Merged

chore(@dpc-sdp/ripple-ui-core): cleanup vue component exports #1173

merged 1 commit into from
May 21, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented May 20, 2024

What I did

  • Cleanup component exports
  • Add missing exports

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this May 20, 2024
@netlify Netlify
Copy link

netlify bot commented May 20, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit f2a3024
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/664abba11f6a9000082c757c

@waitingallday
Copy link
Member

Always meant to automate this, but it's not really worth it now

@dylankelly dylankelly added this pull request to the merge queue May 20, 2024
Merged via the queue into develop with commit 3758eef May 21, 2024
16 checks passed
@dylankelly dylankelly deleted the feature/ui-core-component-exports branch May 21, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @waitingallday @dylankelly