Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-2035] add basic keyboard/search support to dropdowns #1215

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jun 10, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-2035

What I did

  • Add basic keyboard/search support to dropdowns, this mimics native behavior. i.e.
    • Using a single key cycles through options, so hitting "a" multiple times (with delay) will cycle through all options starting with "A"
    • Quickly typing multiple characters will jump to any matching options, for example typing "avo" will jump to "Avocado"

keyboard-nav

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jun 10, 2024
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 24cc4fd
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/66679024ec82e8000875fe36

Copy link

cypress bot commented Jun 10, 2024

Passing run #1886 ↗︎

0 162 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-ui-forms): add basic keyboard/search support to dropdowns
Project: ripple-framework Commit: 24cc4fdc31
Status: Passed Duration: 06:40 💡
Started: Jun 10, 2024 11:42 PM Ended: Jun 10, 2024 11:49 PM

Review all test suite changes for PR #1215 ↗︎

@dylankelly dylankelly added this pull request to the merge queue Jun 10, 2024
Merged via the queue into develop with commit 042450f Jun 11, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the feature/R20-2035-type-to-option branch June 11, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants