Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-2040] sort options aria label #1216

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jun 12, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-2040

What I did

  • Fix sort options aria label, for doesn't work for non labelable elements like our custom dropdown

Before
before

After
after

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jun 12, 2024
Copy link

cypress bot commented Jun 12, 2024

Passing run #1893 ↗︎

0 162 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-search): fix sort options aria label
Project: ripple-framework Commit: e08dc8aad7
Status: Passed Duration: 07:43 💡
Started: Jun 12, 2024 1:18 AM Ended: Jun 12, 2024 1:26 AM

Review all test suite changes for PR #1216 ↗︎

Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit e08dc8a
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6668f93044d1df000862a38c

@dylankelly dylankelly added this pull request to the merge queue Jun 13, 2024
Merged via the queue into develop with commit 30775a8 Jun 13, 2024
8 checks passed
@dylankelly dylankelly deleted the bugfix/R20-2040-sort-label branch June 13, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants