[R20-2041] always ensure expanded menu is visible #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ripple-docs canceled.
|
Passing run #1913 ↗︎
Details:
Review all test suite changes for PR #1223 ↗︎ |
|||||||||||||||
lambry
changed the title
lambry
changed the title
dylankelly
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://digital-vic.atlassian.net/browse/R20-2041
What I did
The latest version of safari on ios was triggering a scroll when the search field was focused, this in turned triggered our menu to be hidden as that's what it does, it hides when the page is scrolled down.
This issue only effected sites using the quick exit as having the quick exit in the menu pushes down the search input down just enough for safari to decided it needs to move up the page so the user can see/access the input field better.
Checklist
For all PR's
For new components only