Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1451] Added missing debouncing to suggestions and limit to 128 chars #1235

Merged
merged 3 commits into from
Jun 25, 2024
Merged

[R20-1451] Added missing debouncing to suggestions and limit to 128 chars #1235

merged 3 commits into from
Jun 25, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/R20-1451

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle self-assigned this Jun 23, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 23, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit cfac365
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/667b57126cae2f00082f17e7

@cypress Cypress
Copy link

cypress bot commented Jun 23, 2024 •
edited
Loading

Passing run #1971 ↗︎

0 172 0 0 Flakiness 0

Details:

test(@dpc-sdp/ripple-tide-search): added tests for max search bar characters
Project: ripple-framework Commit: ab81dabaff
Status: Passed Duration: 08:04 💡
Started: Jun 24, 2024 4:47 AM Ended: Jun 24, 2024 4:55 AM

Review all test suite changes for PR #1235 ↗︎

dylankelly
dylankelly requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@dylankelly dylankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a Cypress test for the input max length ?

@dylankelly dylankelly added this pull request to the merge queue Jun 25, 2024
Merged via the queue into develop with commit 149d8cb Jun 25, 2024
13 of 14 checks passed
@dylankelly dylankelly deleted the bugfix/R20-1451-search-max-chars branch June 25, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@dylankelly dylankelly dylankelly approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

Assignees

@jeffdowdle jeffdowdle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffdowdle @lambry @dylankelly