Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-2027] set default layout background colour #1237

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jun 26, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-2027

What I did

  • Some accessibility tools allow inverting a page, however without the bg being explicitly set this doesn't work well.

Before

Screenshot 2024-06-26 at 2 51 55 PM

After

Screenshot 2024-06-26 at 2 53 36 PM

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jun 26, 2024
Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit f7d5cc0
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/667ba6f27552b90008c81dfc

Copy link

cypress bot commented Jun 26, 2024

Passing run #1982 ↗︎

0 174 0 0 Flakiness 0

Details:

feat(@dpc-sdp/ripple-ui-core): set default layout background colour
Project: ripple-framework Commit: f7d5cc01b8
Status: Passed Duration: 07:13 💡
Started: Jun 26, 2024 5:27 AM Ended: Jun 26, 2024 5:34 AM

Review all test suite changes for PR #1237 ↗︎

Copy link
Member

@waitingallday waitingallday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it on that arabic page from https://digital-vic.atlassian.net/browse/SDPAP-9439 as well just out of curiosity, looks good 👍

@dylankelly dylankelly added this pull request to the merge queue Jun 27, 2024
Merged via the queue into develop with commit 6855576 Jun 27, 2024
15 of 16 checks passed
@dylankelly dylankelly deleted the feature/default-layout-bg branch June 27, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants