Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R20-1433] improve accuracy of more count for dropdowns #1240

Merged
merged 4 commits into from
Jul 1, 2024
Merged

[R20-1433] improve accuracy of more count for dropdowns #1240

merged 4 commits into from
Jul 1, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jun 27, 2024

Issue: https://digital-vic.atlassian.net/browse/R20-1433

What I did

  • Improve accuracy of more count for dropdowns, this mostly just ensures it doesn't display +1 more when there's actually 2 and bit hidden.
before.mov
after.mov

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Jun 27, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 27, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 424018a
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/667e33369bec5900086347d0

@cypress Cypress
Copy link

cypress bot commented Jun 27, 2024 •
edited
Loading

Passing run #1996 ↗︎

0 174 0 0 Flakiness 0

Details:

test(@dpc-sdp/ripple-ui-core): add test change for CI
Project: ripple-framework Commit: 424018a2e4
Status: Passed Duration: 07:22 💡
Started: Jun 28, 2024 3:53 AM Ended: Jun 28, 2024 4:01 AM

Review all test suite changes for PR #1240 ↗︎

dylankelly
dylankelly requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@dylankelly dylankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work on this - can we add some Cypress component tests

@dylankelly dylankelly added this pull request to the merge queue Jul 1, 2024
Merged via the queue into develop with commit 79791b1 Jul 1, 2024
16 checks passed
@dylankelly dylankelly deleted the bugfix/dropdown-count branch July 1, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @dylankelly @jeffdowdle