Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-75] Clear geolocation button errors on search or reset #1279

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: Raised from testing https://digital-vic.atlassian.net/browse/SD-75

What I did

  • Made sure the error message displayed when a user denies location permissions don't stick around after searching or clearing the search.

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle added this to the 2.13.0 milestone Jul 26, 2024
Copy link

cypress bot commented Jul 26, 2024

Passing run #2109 ↗︎

0 186 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-search): clear geolocation button errors on search or r...
Project: ripple-framework Commit: 15e916abf6
Status: Passed Duration: 08:48 💡
Started: Jul 26, 2024 4:12 AM Ended: Jul 26, 2024 4:21 AM

Review all test suite changes for PR #1279 ↗︎

@dylankelly dylankelly merged commit ca89a2c into release/v2.13.0 Jul 29, 2024
6 checks passed
@dylankelly dylankelly deleted the bugfix/SD-75-clear-errors branch July 29, 2024 00:02
@cypress cypress bot mentioned this pull request Jul 29, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants