Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-127] fixed getTaxonomy only getting first 50 pages #1284

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/SD-127

What I did

  • Changed getTaxonomy to utilise the existing 'getEntityList' function, which already handles pagination of the drupal API

How to test

  • See ticket

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@jeffdowdle jeffdowdle added this to the v2.14.0 milestone Aug 7, 2024
Copy link

cypress bot commented Aug 7, 2024



Test summary

186 0 0 0


Run details

Project ripple-framework
Status Passed
Commit 70cea02
Started Aug 7, 2024 2:10 AM
Ended Aug 7, 2024 2:18 AM
Duration 08:09 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@jeffdowdle jeffdowdle merged commit 38be17e into release/2.14.0 Aug 7, 2024
6 checks passed
@jeffdowdle jeffdowdle deleted the bugfix/SD-127-large-taxonomies branch August 7, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants