Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-170] Single line primary nav #1287

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/SD-170

What I did

  • Added the feature flag primaryNavNowrap, to selectively add a class for preventing long primary nav link titles from wrapping to multiple lines.

How to test

  • Cypress

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

Copy link

cypress bot commented Aug 12, 2024



Test summary

188 0 0 0


Run details

Project ripple-framework
Status Passed
Commit 9b6a42f
Started Aug 12, 2024 11:37 PM
Ended Aug 12, 2024 11:46 PM
Duration 09:06 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@dylankelly dylankelly merged commit 6005b29 into release/2.14.0 Aug 13, 2024
13 of 14 checks passed
@dylankelly dylankelly deleted the feat/sd-170-nav-single-line branch August 13, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants