Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-203] fix external links on carousel events #1295

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Aug 15, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-203

What I did

  • Fix external links on carousel events

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

Copy link

cypress bot commented Aug 15, 2024



Test summary

188 0 0 0


Run details

Project ripple-framework
Status Passed
Commit 34bfabf
Started Aug 15, 2024 5:49 AM
Ended Aug 15, 2024 5:57 AM
Duration 08:24 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@waitingallday waitingallday added this to the 2.15.0 milestone Aug 15, 2024
@waitingallday waitingallday changed the base branch from release/2.14.0 to release/2.15.0 August 15, 2024 06:33
@dylankelly dylankelly merged commit d8a2fca into release/2.15.0 Aug 16, 2024
6 checks passed
@dylankelly dylankelly deleted the bugfix/carousel-event-card-link branch August 16, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants