Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-161] add new print event #1304

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Aug 27, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-161

What I did

  • Adds a new print event

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Aug 27, 2024
@lambry lambry added this to the 2.15.0 milestone Aug 27, 2024
Copy link

cypress bot commented Aug 27, 2024

ripple-framework    Run #2171

Run Properties:  status check failed Failed #2171  •  git commit d2a581deaa: feat(@dpc-sdp/nuxt-ripple-analytics): add new print event
Project ripple-framework
Branch Review feature/print-event
Run status status check failed Failed #2171
Run duration 09m 11s
Commit git commit d2a581deaa: feat(@dpc-sdp/nuxt-ripple-analytics): add new print event
Committer David Featherston
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 191
View all changes introduced in this branch ↗︎

Tests for review

Failed  test/features/maps/maps.feature • 1 failed test

View Output

Test Artifacts
Custom collection map component > Map zooms to intended initial location with results hook Test Replay Screenshots

@dylankelly
Copy link
Contributor

test failure is just the flakey maps feature

@dylankelly dylankelly merged commit e09c7a8 into release/2.15.0 Aug 27, 2024
4 of 6 checks passed
@dylankelly dylankelly deleted the feature/print-event branch August 27, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants