Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-250] route breadcrumbs improvement #1318

Merged
merged 1 commit into from
Sep 10, 2024
Merged

[SD-250] route breadcrumbs improvement #1318

merged 1 commit into from
Sep 10, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Sep 6, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-250

What I did

  • Fixes intermittent issue with the routeChange event not always having the latest route information

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added cypress tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Sep 6, 2024
@cypress Cypress
Copy link

cypress bot commented Sep 8, 2024

ripple-framework    Run #2197

Run Properties:  status check passed Passed #2197  •  git commit ba4124d61c: fix(@dpc-sdp/nuxt-ripple-analytics): switch to useRouter for routeChange trackin...
Project ripple-framework
Branch Review feature/route-breadcrumbs
Run status status check passed Passed #2197
Run duration 10m 08s
Commit git commit ba4124d61c: fix(@dpc-sdp/nuxt-ripple-analytics): switch to useRouter for routeChange trackin...
Committer David Featherston
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 194
View all changes introduced in this branch ↗︎

@dylankelly dylankelly merged commit e29372c into release/2.16.0 Sep 10, 2024
6 checks passed
@dylankelly dylankelly deleted the feature/route-breadcrumbs branch September 10, 2024 00:03
@waitingallday waitingallday added this to the 2.16.0 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylankelly dylankelly dylankelly approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lambry @dylankelly @waitingallday