Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-274] update download attribute, add space between grant downloads #1324

Merged
merged 2 commits into from
Sep 17, 2024
Merged

[SD-274] update download attribute, add space between grant downloads #1324

merged 2 commits into from
Sep 17, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Sep 16, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-274

What I did

  • update download attribute
  • add space between grant downloads

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Sep 16, 2024
@lambry lambry added this to the 2.17.0 milestone Sep 16, 2024
@lambry lambry merged commit 49b6810 into release/2.17.0 Sep 17, 2024
13 of 14 checks passed
@lambry lambry deleted the bugfix/grants-download-name branch September 17, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waitingallday waitingallday waitingallday approved these changes

@dylankelly dylankelly dylankelly approved these changes

@jeffdowdle jeffdowdle jeffdowdle approved these changes

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lambry @waitingallday @dylankelly @jeffdowdle