Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-251] publication events #1332

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Sep 18, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-251

What I did

  • Updates publication page link event as per spec

NOTE: this was branched from #1323 to make use of it's test updates, that PR can be merged before looking at this to make this easier to look at.

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry added this to the 2.17.0 milestone Sep 18, 2024
@lambry lambry self-assigned this Sep 18, 2024
# Conflicts:
#	packages/ripple-test-utils/step_definitions/common/navigation.ts
Copy link

cypress bot commented Sep 24, 2024

ripple-framework    Run #2252

Run Properties:  status check passed Passed #2252  •  git commit 7e7001425e: Merge branch 'release/2.17.0' into feature/publication-events
Project ripple-framework
Branch Review feature/publication-events
Run status status check passed Passed #2252
Run duration 08m 55s
Commit git commit 7e7001425e: Merge branch 'release/2.17.0' into feature/publication-events
Committer David Featherston
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 201
View all changes introduced in this branch ↗︎

@dylankelly dylankelly merged commit 6693cf4 into release/2.17.0 Sep 24, 2024
13 of 14 checks passed
@dylankelly dylankelly deleted the feature/publication-events branch September 24, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants