Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-256] - Added form abandon event #1336

Merged
merged 2 commits into from
Sep 24, 2024
Merged

[SD-256] - Added form abandon event #1336

merged 2 commits into from
Sep 24, 2024

Conversation

jeffdowdle
Copy link
Contributor

@jeffdowdle jeffdowdle commented Sep 23, 2024 •
edited
Loading

Relies on the form start event PR, keeping in draft until that's merged

Issue: https://digital-vic.atlassian.net/jira/software/c/projects/SD/boards/360?selectedIssue=SD-256

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@cypress Cypress
Copy link

cypress bot commented Sep 23, 2024 •
edited
Loading

ripple-framework    Run #2245

Run Properties:  status check passed Passed #2245  •  git commit e749444cae: fix(@dpc-sdp/ripple-ui-forms): fixed missing import for rplform
Project ripple-framework
Branch Review feature/SD-256-form-abandon-event
Run status status check passed Passed #2245
Run duration 08m 49s
Commit git commit e749444cae: fix(@dpc-sdp/ripple-ui-forms): fixed missing import for rplform
Committer Jeffrey Dowdle
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 197
View all changes introduced in this branch ↗︎

Base automatically changed from feature/SD-257-form-start-event to release/2.17.0 September 24, 2024 00:12
@jeffdowdle jeffdowdle added this to the 2.17.0 milestone Sep 24, 2024
@jeffdowdle jeffdowdle marked this pull request as ready for review September 24, 2024 00:14
@dylankelly dylankelly merged commit 1d9fc1d into release/2.17.0 Sep 24, 2024
11 of 12 checks passed
@dylankelly dylankelly deleted the feature/SD-256-form-abandon-event branch September 24, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@dylankelly dylankelly dylankelly approved these changes

@waitingallday waitingallday Awaiting requested review from waitingallday

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffdowdle @lambry @dylankelly