Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Analytics context #1354

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jeffdowdle
Copy link
Contributor

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 34f6945
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6716d353329ee20008fd1ef4

Copy link

cypress bot commented Oct 21, 2024

ripple-framework    Run #2311

Run Properties:  status check failed Failed #2311  •  git commit 34f6945ece: feat: proof of context for analytics context
Project ripple-framework
Branch Review experiment/SD-389-analytics-context
Run status status check failed Failed #2311
Run duration 10m 34s
Commit git commit 34f6945ece: feat: proof of context for analytics context
Committer Jeffrey Dowdle
View all properties for this run ↗︎

Test results
Tests that failed  Failures 13
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 194
View all changes introduced in this branch ↗︎

Tests for review

Failed  landingpage/page-components.feature • 6 failed tests

View Output

Test Artifacts
Home page > Page component - Accordion Test Replay Screenshots
Home page > Page component - Accordion (Open/close all) Test Replay Screenshots
Home page > Page component - Card carousel (Slider) Test Replay Screenshots
Home page > Page component - Media Gallery (Slider) Test Replay Screenshots
Home page > Page component - Media Gallery (Modal) Test Replay Screenshots
Home page > Page component - Complex image/Media Embed Test Replay Screenshots
Failed  maps/maps.feature • 6 failed tests

View Output

Test Artifacts
Custom collection map component > Popup - 'popover' type Test Replay Screenshots
Custom collection map component > Popup - 'sidebar' type Test Replay Screenshots
Custom collection map component > Popup - 'popover' type with sidepanel Test Replay Screenshots
Custom collection map component > Popup - 'sidebar' type with sidepanel Test Replay Screenshots
Custom collection map component > Popup - Two pins in same location Test Replay Screenshots
Custom collection map component > Reaching the maximum zoom level will show clustered features in grouped popup Test Replay Screenshots
Failed  site/analytics.feature • 1 failed test

View Output

Test Artifacts
Analytics > Back to top Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant