Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRM-1608] add function to remove new lines #1355

Open
wants to merge 2 commits into
base: release/2.19.0
Choose a base branch
from

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Oct 21, 2024

Issue: https://digital-vic.atlassian.net/browse/SRM-1608

What I did

  • Add a function to remove 'new lines' added via the CMS, these 'new lines' aren't shown on the frontend and cause hydration mismatch errors.

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry added this to the 2.19.0 milestone Oct 21, 2024
@lambry lambry self-assigned this Oct 21, 2024
Copy link

cypress bot commented Oct 22, 2024

ripple-framework    Run #2312

Run Properties:  status check passed Passed #2312  •  git commit af6d0950e1: chore(@dpc-sdp/ripple-tide-api): rename function to getPlainText
Project ripple-framework
Branch Review feature/hydration-errors
Run status status check passed Passed #2312
Run duration 10m 10s
Commit git commit af6d0950e1: chore(@dpc-sdp/ripple-tide-api): rename function to getPlainText
Committer David Featherston
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 207
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants