Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R20-1274] add site wide corner graphics, remove content type headers #723

Merged
merged 14 commits into from
Jul 27, 2023

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Jul 25, 2023

Issue: https://digital-vic.atlassian.net/browse/R20-1274

What I did

  • Add site wide corner graphics
  • Remove content type headers
  • Remove stray '3's
  • Fix site data fetch on 404 pages

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@codesandbox
Copy link

codesandbox bot commented Jul 25, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@netlify
Copy link

netlify bot commented Jul 25, 2023

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit d1ecffc
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/64c06156f7d9ab00086c8dee

Copy link
Contributor

@dylankelly dylankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@cypress
Copy link

cypress bot commented Jul 26, 2023

Passing run #54 ↗︎

0 79 0 0 Flakiness 0

Details:

fix(nuxt-app): update full-form.json header
Project: ripple-framework Commit: d1ecffceb8
Status: Passed Duration: 02:53 💡
Started: Jul 26, 2023 12:04 AM Ended: Jul 26, 2023 12:06 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jeffdowdle jeffdowdle added this pull request to the merge queue Jul 27, 2023
Merged via the queue into develop with commit 0e68f67 Jul 27, 2023
4 checks passed
@dylankelly dylankelly added this to the 2.1.0 milestone Aug 7, 2023
@lambry lambry deleted the feature/R20-1274-hero-headers branch August 9, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants